Skip to content

Simplify PublicTopLevelProgramGenerator #60222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 22, 2025
Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 6, 2025

Re-opening #59601

cc @captainsafia

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 6, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 6, 2025
@Youssef1313 Youssef1313 changed the title Simplify PublicTopLevelProgramGeneratorPatch 2 Simplify PublicTopLevelProgramGenerator Feb 6, 2025
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reopening this!

The build failures are unrelated to the changeset included here. I'll rekick the build and hope that it goes through.

@captainsafia
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia captainsafia enabled auto-merge (squash) February 11, 2025 05:54
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 18, 2025
@Youssef1313
Copy link
Member Author

@captainsafia Could you re-run the pipeline please? I guess the failure here was unrelated

@Youssef1313
Copy link
Member Author

Ping @captainsafia

@captainsafia
Copy link
Member

/azp run

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 22, 2025
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia captainsafia merged commit 2fbb20d into dotnet:main Feb 22, 2025
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Feb 22, 2025
@Youssef1313 Youssef1313 deleted the patch-2 branch February 22, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants