Refactor private PushAuthorizationRequest #59990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@dotnet-policy-service agree |
dotnet-policy-service
bot
added
the
community-contribution
halter73
reviewed
Jan 28, 2025
halter73
approved these changes
Jan 29, 2025
halter73
requested changes
Jan 29, 2025
An exception was created but not thrown. When backtracking the usage of the private method, the PAR-endpoint was already guarded for null/empty value. The initial guard for empty is there for future usages, the call is redundant now.
marcusber
force-pushed
the
marcusber/release/9.0/throwParException
branch
from
598ac5a to
246b106
Compare
marcusber
requested review from
wtgodbe,
a team,
BrennanConroy,
JamesNK,
mgravell,
captainsafia,
brunolins16,
javiercn and
mkArtakMSFT
as code owners
|
@halter73 The branch name is missleading, but the branch is up to date with main. |
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
An exception was created but not thrown. When backtracking the usage of the private method, the PAR-endpoint was already guarded for null/empty value. The initial guard for empty is there for future usages, the call is redundant now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor private PushAuthorizationRequest
An exception was created but not thrown. Make relevant changes to remove that.
Description
An exception was created but not thrown. When backtracking the usage of the private method, the PAR-endpoint was already guarded for empty PAR-enpoints.
Pass in the PAR-endpoint as non-null reference to the private method. Remove the exception that was created and not thrown.
Existing unit tests never reaches the private method due to guards in the calling method.
I'm not sure which branch this PR should target. It should be compatible with main when cherry-picked.