Skip to content

[Blazor] Allow cascading value subscribers to get added and removed during change notification #57243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

MackinnonBuck
Copy link
Member

[Blazor] Allow cascading value subscribers to get added and removed during change notification

Updates cascading value change notification logic to operate on a copy of the subscriber list to avoid cases where the list could get mutated during enumeration.

Fixes #56741
Fixes #53075

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner August 9, 2024 00:21
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 9, 2024
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MackinnonBuck MackinnonBuck merged commit a081d5d into main Aug 11, 2024
26 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/fix-cascading-values branch August 11, 2024 20:19
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Aug 11, 2024
@MackinnonBuck
Copy link
Member Author

/backport to release/8.0

Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/10356462724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
3 participants