CSS manipulation + tests #2
Conversation
| * dom.removeClass(document.body, 'loading'); | ||
| * | ||
| * @example | ||
| * dom.removeClas(document.body, 'loading', 'pending'); |
|
|
||
| 'null class'() { | ||
| assert.doesNotThrow(function () { | ||
| dom.containsClass(targetElement, null); |
There was a problem hiding this comment.
I assume this test case isn't testing passing nothing (as opposed to others with the same description for the other APIs) because TS makes that impossible without suppressing a warning. I'd vote to just remove this test case for this function then.
The way this is written, it actually will throw (this test fails in IE9), but see previous remark in that null shouldn't actually throw to be consistent with native implementations.
There was a problem hiding this comment.
I updated all tests to be consistent with native implementations and to have clearer descriptions.
|
This should be ready for another review. Thanks! |
|
Merged via 8d5def0. I removed SVG testing and made the functions expect HTMLElement, since this really doesn't support SVG elements (created via |
This PR includes
addClass,containsClass,removeClass,toggleClass, and associated unit tests.