Skip to content

Fix HtmlModule 10 upgrade issues with localized sites #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tvatavuk
Copy link
Contributor

Fixes #6494

Summary

There is an upgrade issue affecting localized sites. After upgrading the HtmlModule to versions 10.00.00 or 10.00.01, exceptions may occur as explained in #6494.

The migration from the built-in HTML workflow is not correctly mapped to DNN content workflows when workflow names and states are localized. This depends on the admin-selected language at the time of site creation.

This fix addresses that issue.

This PR makes upgrading to DNN 10.00.02+ to resolve these errors. Alternatively, for sites already on 10.00.00 or 10.00.01, running the SQL script at
DesktopModules\HTML\Providers\DataProviders\SqlDataProvider\10.00.02.SqlDataProvider in the DNN SQL Console can also resolve the issues caused by content workflow localization.

TODO:

  • Halt upgrade if custom HTML workflows are detected
  • SQL script to fix localization issues after HTML upgrade
  • Improved SQL script to create missing content workflows and states
  • Migrate HTML workflow logic from SQL-only to C# for better flexibility during development
  • Enhance HtmlModule to be more robust in similar scenarios
  • Refine SQL scripts for best practices

@bdukes bdukes added this to the 10.0.2 milestone May 29, 2025
@valadas
Copy link
Contributor

valadas commented May 29, 2025

Awesome, thanks for taking care of this @tvatavuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: HtmlModule 10 upgrade error
3 participants