Display indented SQL queries in expanded views. #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not executed the selenium tests yet (simply following the contributing doc resulted in an error ( |
Also, use expanded form (thus with indentation) in SQL select/explain/profile views.
thomas-riccardi
force-pushed
the
indent-sql-queries
branch
from
c31c778 to
a8413f6
Compare
auvipy
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reuses the query details toggle to display the indented version: the default view does not change.
This uses
and<br/>to convertsqlparse.formatfrom text to html visual indentation, it has a small visual glitch with the+button to toggle details on theSELECTfirst line, but hopefully it's OK for everyone.Also, use expanded form in SQL select/explain/profile views to profit from the indented formatting.
Result:
