ImportError: cannot import name 'get_show_toolbar'

[timb07]

Since commit 68c4410, requests fail with ImportError: cannot import name 'get_show_toolbar'. (It was working fine with the previous commit.) Here's the relevant part of the traceback:

  File "/home/sid2/.local/lib/python3.5/site-packages/django/core/wsgi.py", line 14, in get_wsgi_application
    return WSGIHandler()
  File "/home/sid2/.local/lib/python3.5/site-packages/django/core/handlers/wsgi.py", line 151, in __init__
    self.load_middleware()
  File "/home/sid2/.local/lib/python3.5/site-packages/django/core/handlers/base.py", line 56, in load_middleware
    mw_class = import_string(middleware_path)
  File "/home/sid2/.local/lib/python3.5/site-packages/django/utils/module_loading.py", line 20, in import_string
    module = import_module(module_path)
  File "/usr/lib/python3.5/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/home/sid2/.local/lib/python3.5/site-packages/debug_toolbar/middleware.py", line 17, in <module>
    from debug_toolbar.toolbar import DebugToolbar
  File "/home/sid2/.local/lib/python3.5/site-packages/debug_toolbar/toolbar.py", line 135, in <module>
    urlpatterns = DebugToolbar.get_urls()
  File "/home/sid2/.local/lib/python3.5/site-packages/debug_toolbar/toolbar.py", line 121, in get_urls
    from . import views
  File "/home/sid2/.local/lib/python3.5/site-packages/debug_toolbar/views.py", line 7, in <module>
    from debug_toolbar.decorators import require_show_toolbar
  File "/home/sid2/.local/lib/python3.5/site-packages/debug_toolbar/decorators.py", line 5, in <module>
    from debug_toolbar.middleware import get_show_toolbar
ImportError: cannot import name 'get_show_toolbar'

I'm using Django 1.11, so I'm keen to use a recent commit that includes the fix for #910. (I'm using Python 3.5.2.) The test suite (run with tox -e py35-dj111) passes.

[matthiask]

Hmm. Looks very much like a circular import error. Does it work if you move the get_show_toolbar import in decorators.py inside def inner?

[goblinJoel]

I can confirm we got this error at my company when we tried to use the development version of djdt on one of our dev servers, which uses uwsgi. (It was this error or a very similar one that also looked like a circular import error trying to import middleware from a view that was indirectly imported from middleware.) The error did not occur for us using manage.py runserver, but it did through uwsgi.

@timb07 We got around this temporarily by using the 1.7-tagged commit, with the #910 commit git cherry-pick'd on top of it. (Plus an additional commit of our own to ignore certain widget templates.) Not sure if that is a valid workaround for your case.

[timb07]

@matthiask Yes, that fix works. Thanks for suggesting it.

[matthiask]

Great! Do you want to submit a pull request?

…

On May 4, 2017 00:01, "Tim Bell" ***@***.***> wrote: @matthiask <https://github.com/matthiask> Yes, that fix works. Thanks for suggesting it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#938 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAKQ0xnQB6gXVphOXBq2PR6CCW6FtcVks5r2PkngaJpZM4NO7Tm> .

[timb07]

Done!