Skip to content

Refactor and use latest Humanizer version #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Conversation

cdhunt
Copy link
Collaborator

@cdhunt cdhunt commented May 29, 2024

This PR works for PowerShell 7.4. All tests pass. Some tests fail against 7.2 and 7.3. The latest version of Humanizer doesn't work on 5.1 with simple netstandard2.0 targeting. It might be possible to get working with some additional work, but I don't have much incentive to make that time investment.

The files have been reorganized. The Humanizer library is pulled from Nuget and includes all available cultures. I haven't tested any and culture isn't explicitly passed to any methods, but it might work.

Help has been added to all of the functions and markdown generated.

Tests have been updated to use Pester 5.5.

build.ps1 handles most of the CI work including generating the PSD1 dynamically. A GitHub Actions workflow runs PSScriptAnalyzer and tests for multiple versions of PS. The repo needs a NUGETAPIKEY secret for publishing to the PowerShellGallery.

Fixes #17, #10

@cdhunt cdhunt self-assigned this May 29, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@cdhunt cdhunt marked this pull request as ready for review May 29, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Humanizer version and improve module layout
1 participant