Skip to content

Registry Operator should update deployment when headless boolean is updated #1258

Closed
@kim-tsao

Description

@kim-tsao

/kind user-story

Which area this user story is related to?

/area registry

User Story

As a devfile registry admin I want to update my existing deployment so it can run either headless or non-headless

Currently, when a DevfileRegistry is deployed and a patch update is made changing the headless boolean from true to false, I expect an additional pod for the registry-viewer to be created but the update does not get triggered because we do not handle that configuration: https://github.com/devfile/registry-operator/blob/main/controllers/update.go

cat <<EOF | oc apply -n test -f -
apiVersion: registry.devfile.io/v1alpha1
kind: DevfileRegistry
metadata:
  name: devfile-registry-test
spec:
  tls:
    enabled: false
  devfileIndexImage: quay.io/devfile/devfile-index:next
  headless: true
EOF

Acceptance Criteria

  • Updates should be supported when headless is toggled between true and false
  • Unit/Controller tests are added
  • Documentation for DevfileRegistry CRD updated

Updated 2023-12-21 by: @michael-valdron

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/registryDevfile registry for stacks and infrastructurekind/user-storyUser story for new enhancement

    Type

    No type

    Projects

    Status

    Done ✅

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions