feat(http/unstable): unstable-file-server
#6668
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6668 +/- ##
==========================================
- Coverage 94.69% 94.08% -0.62%
==========================================
Files 562 561 -1
Lines 46646 41661 -4985
Branches 6569 6558 -11
==========================================
- Hits 44173 39197 -4976
+ Misses 2430 2416 -14
- Partials 43 48 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| stdout: "piped", | ||
| stderr: "piped", | ||
| }).spawn(); | ||
| await readUntilMatch(child.stderr, "Listening"); |
There was a problem hiding this comment.
Surprised to see that the output of deno serve prints to stderr instead of stdout. Is this a bug?
| }).spawn(); | ||
| await readUntilMatch(child.stderr, "Listening"); | ||
| const response = await fetch(`http://localhost:${port}`); | ||
| assertEquals(response.status, 200); |
There was a problem hiding this comment.
Haven't been able to look deep into why this fails. Any help would be appreciated.
|
The entrypoint name seems suggesting this will be merged to Maybe better to give a different name? |
|
Yes, I should've clarified that my intention was that this was to replace the current Alternatively, we can depend on denoland/deno#29447 to be implemented as to minimise breaking changes and avoiding having to create a new endpoint. |
This new module is an updated version of
@std/http/file-serverthat usesdeno serve, which takes care of the heavy lifting of some argument parsing and can be run in parallel service workers thanks to--parallel. It directly relies on the exported symbols of@std/http/file-serverand a few kinks need to be figured out.Closes #5681