fix: Don't include modules via a macro #935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Turns out
rustfmt
won't format module files that are included via a macro. See here.This meant things like
log_segment.rs
that were included viainternal_mod!
were not getting formatted.This removes that macro and just uses the "double include" gated by feature flags, which
rustfmt
can handle.How was this change tested?
Making sure that miss-formatted code in the effected modules is now formatted when running
cargo fmt
.