Skip to content

Convert components tests to typescript #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2021
Merged

Convert components tests to typescript #117

merged 7 commits into from
Jul 28, 2021

Conversation

mattrunyon
Copy link
Collaborator

Closes #111

@mattrunyon mattrunyon requested a review from mofojed July 16, 2021 22:51
@mattrunyon mattrunyon self-assigned this Jul 16, 2021
@mattrunyon mattrunyon requested a review from mofojed July 22, 2021 23:02
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you fix up, remember to re-request the review from me

@mattrunyon mattrunyon requested a review from mofojed July 27, 2021 17:17
mofojed
mofojed previously approved these changes Jul 27, 2021
@mattrunyon mattrunyon requested a review from mofojed July 28, 2021 20:49
@mattrunyon mattrunyon merged commit 100c913 into main Jul 28, 2021
@mattrunyon mattrunyon deleted the mattrunyon_111 branch July 28, 2021 21:10
@mofojed mofojed mentioned this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finished converting @deephaven/components test files to TypeScript
2 participants