File Explorer drag and drop to move files #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add drag and drop styling Some clean up before review
- Fix Shift-Click selection. It wasn't updating the selection properly, this has been broken since powell --> A couple of functions like handleItemBlur and handleItemFocus were unnecessary, just removed them. - Update selection after dropping - Emit signal for all renamed files
…emList - Got it mostly done... except a lot of the styling... - Don't want to translate items when dragging, which is what react-beautiful-dnd does out of the box
- Fixed up stealing focus when opening preview notebook - Mostly functioning but the render function isn't getting the dropTargetItem... I think there's too much rendering going on as well, probably not memoizing something properly
- Needed to reset the mouse state when a drag starts - Still need to fix up the styling
Wasn't checking if the dataTransfer items list had no items.
- Drag past the last element to drop at the root
|
Adding @dsmmcken to review styling |
vbabich
requested changes
Jul 22, 2021
Co-authored-by: vbabich <[email protected]>
Co-authored-by: vbabich <[email protected]>
No need for updateDimensions to be called, since the AutoSizer already properly handles resizing
dsmmcken
previously requested changes
Jul 22, 2021
There was a problem hiding this comment.
- 1. Dragging folder into self deletes folder 😨
- 2, Styling of selection should match command history exactly see commandhistoryitem.scss, maybe even re-use? note the use of focus, active, hover, focus-within active styling and borders.
- 3. Selecting multiple items, then initiating a drag shows the drag item that initiated as de-selected, rather than remaining selected
- 4. ctrl/shift selection clicks shouldn't trigger opening of that notebook.
|
|
@dsmmcken Should I be building the border/transitions directly into ItemList? Not sure if there was a reason that styling was only added to command history or not. In any case I've pushed a change with the styling applied to FileList |
Some default styling was being applied when dragging items
Could re-use between filelist and command history list, but this list is also used a bunch in the table sidebar menu, where it has different styling |
vbabich
previously approved these changes
Jul 23, 2021
vbabich
approved these changes
Jul 23, 2021
mofojed
dismissed
dsmmcken’s stale review
I've fixed all his changes and he verbally approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyboardIndextofocusIndexinItemList, and fire anonFocusChangeevent to allow handling.Fixes Notebook UI: Drag and Drop to move #86