Skip to content

Bump Astro to 5.8.1 and Vite to 6.3.5 (for @astrojs/react) #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bmartinez287
Copy link
Collaborator

How This PR Solves The Issue

Updates npm packages and it's dependencies.

@bmartinez287 bmartinez287 changed the title Web updates - May 2025 npm updates - May 2025 May 11, 2025
Copy link

cloudflare-workers-and-pages bot commented May 11, 2025

Deploying ddev-com-front-end with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d2af58
Status: ✅  Deploy successful!
Preview URL: https://bc08f9c2.ddev-com-front-end.pages.dev
Branch Preview URL: https://20250511-bmartinez-websiteup.ddev-com-front-end.pages.dev

View logs

@stasadev stasadev force-pushed the 20250511_bmartinez_websiteupdate branch from 9a14901 to 4d2af58 Compare June 3, 2025 18:32
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran

npx @astrojs/upgrade
npm update

And fixed Astro preview on the 4321 port after updating @astrojs/react.

@bmartinez287, it seems to be good, I'll check it more carefully tomorrow (side by side comparison).

@@ -15,7 +15,7 @@ export default defineConfig({
site: "https://ddev.com",
vite: {
server: {
allowedHosts: true, // leave this unchanged for DDEV!
allowedHosts: ["." + process.env.DDEV_TLD], // leave this unchanged for DDEV!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowedHosts: true doesn't work anymore in vite v6:

I saw this when I opened ddev launch :4321:

Blocked request. This host ("ddev.com.ddev.site") is not allowed.
To allow this host, add "ddev.com.ddev.site" to `server.allowedHosts` in vite.config.js.

So I updated it to accept DDEV_TLD subdomains.

This is needed for @astrojs/react v3 (vite v5) to @astrojs/react v4 (vite v6) update.

@stasadev stasadev changed the title npm updates - May 2025 Bump Astro to 5.8.1 and Vite to 6.3.5 (for @astrojs/react) Jun 3, 2025
@bmartinez287
Copy link
Collaborator Author

I forgot I had this PR open. Thanks for those fixes. I will test it tomorrow, and if it goes well. We should be good to merge it.

@stasadev stasadev mentioned this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants