Add support for ATRIS #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
added
host:atris
blocked
|
Per the blessing from @matrss we are cleared to go ahead to index ATRIS. Moreover, there is apparently no need for the token, so let's make it work anonymously for ATRIS (if no token, do not authenticate). #58 was just merged |
yarikoptic
removed
the
blocked
jwodder
force-pushed
the
gh-47b
branch
2 times, most recently
from
8788c1e to
cbb9320
Compare
yarikoptic
requested changes
Feb 21, 2025
src/find_datalad_repos/diff.py
Outdated
| @@ -76,6 +77,9 @@ def main( | |||
| for hubr in to_record.hub_datalad_org: | |||
| if hubr.id not in old_hub_repos: | |||
| new_record.hub_datalad_org.append(hubr) | |||
| for atrisr in to_record.atris: | |||
| if atrisr.id not in old_atris_repos: | |||
| new_record.atris.append(atrisr) | |||
There was a problem hiding this comment.
could data structure of RepoRecord and code here be made more generic and just be done "per each RepoHost" and avoid code duplication for each possible repo?
There was a problem hiding this comment.
a003ea8 is the best I can come up with without upsetting mypy.
jwodder
force-pushed
the
gh-47b
branch
2 times, most recently
from
c12b307 to
9719a91
Compare
yarikoptic
approved these changes
Feb 24, 2025
|
@yarikoptic So, can this PR be merged now? |
|
yes, good from my perspective, THANK YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #47.
This PR includes updates to
datalad-repos.jsonand the READMEs for ATRIS. Fetching all of the repositories took 26 seconds.