Skip to content

fix(renderer): export parse condition function #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

Hyperkid123
Copy link
Member

closes #802

@Hyperkid123 Hyperkid123 added the enhancement New feature or request label Sep 16, 2020
@Hyperkid123 Hyperkid123 requested a review from rvsia September 16, 2020 06:55
Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this is going to enhance custom validators, but sure, there is no reason to keep it internal.

However, we should not encourage people to use it without a proper testing, as it's an internal function, so it can be changed anytime.

@rvsia rvsia added the renderer React form renderer PR label Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #807 into master will not change coverage.
The diff coverage is 97.43%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #807   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files         212      213    +1     
  Lines        3322     3322           
  Branches     1082     1082           
=======================================
  Hits         3080     3080           
  Misses        242      242           
Impacted Files Coverage Δ
...react-form-renderer/src/form-renderer/condition.js 97.56% <ø> (+0.06%) ⬆️
...s/react-form-renderer/src/files/parse-condition.js 97.43% <97.43%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4f31e...06ec51a. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 0985784 into master Sep 16, 2020
@Hyperkid123 Hyperkid123 deleted the export-parse-condition branch September 16, 2020 07:35
@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 2.8.22 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making condition evaluation more generic
2 participants