fix(renderer): Do not override initial values with set values.

[Hyperkid123]

Fixes #1224

Description

Field initial value is being overridden if a set condition is met during initialization phase

Schema (if applicable)

    const schema = {
      fields: [
        {
          component: 'text-field',
          name: 'field-1',
          label: 'first name',
        },
        {
          component: 'text-field',
          name: 'field-2',
          label: 'last name',
        },
        {
          component: 'text-field',
          name: 'field-3',
          label: 'occupation',
          condition: {
            sequence: [
              {
                and: [
                  { when: 'field-1', is: 'james' },
                  { when: 'field-2', is: 'bond' },
                ],
                then: { set: { 'field-3': 'SPY' } },
                else: { visible: true },
              },
              {
                and: [
                  { when: 'field-1', is: 'steve' },
                  { when: 'field-2', is: 'jobs' },
                ],
                then: { set: { 'field-3': 'CEO' } },
                else: { visible: true },
              },
            ],
          },
        },
      ],
    };

Checklist: (please see documentation page for more information)

• Yarn build passes
• Yarn lint passes
• Yarn test passes
• Test coverage for new code (if applicable)

[DataDrivenFormsBot]

A new version (fix) will be released: v3.16.11 [DataDrivenFormsBot]

[codecov]

Codecov Report

Merging #1225 (ff17971) into master (1c46635) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1225   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files         209      209           
  Lines        3591     3593    +2     
  Branches     1255     1256    +1     
=======================================
+ Hits         3417     3419    +2     
  Misses        174      174           

Impacted Files	Coverage Δ
...ges/react-form-renderer/src/condition/condition.js	97.67% <100.00%> (+0.11%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[rvsia]

I think this should be checking modified instead of dirty so after users change its value, the setter always run (even users go back to the initial value.)

meta.initial !== meta.value is dirty otherwise

[Hyperkid123]

But that would differ from current behavior. If a setter runs and then the user manually changes a field, the seter never overrides the manually changed value. This one is a real head scratcher.

[rvsia]

🎉 This PR is included in version 3.16.11 🎉

The release is available on

• react-form-renderer (@latest dist-tag)

• ant-component-mapper (@latest dist-tag)

• blueprint-component-mapper (@latest dist-tag)

• carbon-component-mapper (@latest dist-tag)

• mui-component-mapper (@latest dist-tag)

• pf4-component-mapper (@latest dist-tag)

• suir-component-mapper (@latest dist-tag)

Data-Driven-Forms.org!