Skip to content

Test Pandas Series is writeable #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jakirkham
Copy link
Member

Follow-up to PR ( #3967 ) and issue ( #3943 )

Includes a test to ensure a Pandas Series is writeable after round-trip serialization.

@jakirkham jakirkham changed the title Test pandas Series is writeable Test Pandas Series is writeable Jul 28, 2020
@quasiben
Copy link
Member

Looks like this is failing on the test submitted in the PR:
https://travis-ci.org/github/dask/distributed/jobs/712415247#L1560

@jakirkham
Copy link
Member Author

Yeah I saw that last night. This is weird as it passed locally. Will look into it.

@mrocklin
Copy link
Member

Checking in. Do we know what happened here? I ran into buffer source array is read-only errors on 2.21.0 recently and I'm curious if our latest release is broken.

@jakirkham
Copy link
Member Author

The fix got merged after the last release unfortunately ( #3967 ). I suppose we could push out a patch release with that fix. Though we are planning to release tomorrow ( dask/community#77 )

A separate question is why this test doesn't work. Though people have already confirmed that PR does.

@mrocklin
Copy link
Member

Ah ok, so we just need to release. Grand. Thanks @jakirkham !

@jakirkham jakirkham mentioned this pull request Jul 31, 2020
@jakirkham jakirkham deleted the tst_pandas_series_writeable branch August 4, 2020 00:38
@jakirkham
Copy link
Member Author

This test was included as part of PR ( #4004 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants