-
Notifications
You must be signed in to change notification settings - Fork 83
modifying DWDS Injector to always inject client and introduce useDwdsWebSocketConnection flag #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I have a fix out for the existing test failures that should clear them up. Feel free to land your change before that makes it's way in though. |
… it to trigger main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good, thanks Jessy! I haven't gone through your spreadsheet to make sure things are aligned there, but that'd be a good exercise to do.
await _extensionUri, | ||
); | ||
} | ||
// Always inject the debugging client and hoist the main function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means we're injecting the client when doing AMD + web-server, which wasn't the case before unless start-paused
was passed, is that right? I don't have an objection to that addition, but I just want to make sure that doesn't break anything and this is intentional.
), | ||
if (!(dartModuleStrategy == 'ddc-library-bundle')) { | ||
if (_isChromium) { | ||
_sendConnectRequest( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this in a method that gets used here and below.
..instanceId = dartAppInstanceId | ||
..entrypointPath = dartEntrypointPath, | ||
), | ||
if (!(dartModuleStrategy == 'ddc-library-bundle')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or simply !=
:D
..instanceId = dartAppInstanceId | ||
..entrypointPath = dartEntrypointPath, | ||
), | ||
if (!(dartModuleStrategy == 'ddc-library-bundle')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we handle useDwdsWebSocketConnection
here? It seems like if that flag was passed then we should run main immediately as well in the AMD format, right?
useDwdsWebSocketConnection
flag to control to control communication protocol (web-socket vs chrome).ddcLibraryBundle/Web-server
code path for now and will be repaced when the socket-based DWDS is ready.Related to dart-lang/sdk#60289.
Sibling PR in flutter tools: flutter/flutter#170612.