modifying DWDS Injector to always inject client and introduce useDwdsWebSocketConnection flag #2629
Conversation
|
I have a fix out for the existing test failures that should clear them up. Feel free to land your change before that makes it's way in though. |
… it to trigger main
jyameo
changed the title
| await _extensionUri, | ||
| ); | ||
| } | ||
| // Always inject the debugging client and hoist the main function. |
There was a problem hiding this comment.
This means we're injecting the client when doing AMD + web-server, which wasn't the case before unless start-paused was passed, is that right? I don't have an objection to that addition, but I just want to make sure that doesn't break anything and this is intentional.
| ), | ||
| if (!(dartModuleStrategy == 'ddc-library-bundle')) { | ||
| if (_isChromium) { | ||
| _sendConnectRequest( |
There was a problem hiding this comment.
Let's put this in a method that gets used here and below.
| ..instanceId = dartAppInstanceId | ||
| ..entrypointPath = dartEntrypointPath, | ||
| ), | ||
| if (!(dartModuleStrategy == 'ddc-library-bundle')) { |
| ..instanceId = dartAppInstanceId | ||
| ..entrypointPath = dartEntrypointPath, | ||
| ), | ||
| if (!(dartModuleStrategy == 'ddc-library-bundle')) { |
There was a problem hiding this comment.
How should we handle useDwdsWebSocketConnection here? It seems like if that flag was passed then we should run main immediately as well in the AMD format, right?
useDwdsWebSocketConnectionflag to control to control communication protocol (web-socket vs chrome).ddcLibraryBundle/Web-servercode path for now and will be repaced when the socket-based DWDS is ready.Related to dart-lang/sdk#60289.
Sibling PR in flutter tools: flutter/flutter#170612.