`Invalid vm isolate snapshot seen` when running `webdev` `e2e_test.dart` on Windows

[bkonyi]

After 08252fc we've started seeing the Invalid vm isolate snapshot seen for webdev's e2e_test.dart on Windows. Based on a quick look, the VM isolate apparently is missing its magic number.

[a-siva]

A change was added to provide a proper message here https://dart-review.googlesource.com/c/sdk/+/402202

It is highly likely we have a path in this test which is loading an AOT snapshot of dart2js into a VM that is running in JIT mode

[DanTup]

I'm not sure if this is the same issue or I should raise in flutter/flutter, but I see this same error when trying to use flutter build web. Both my Flutter SDK and test project paths have spaces in the name (which a related issue above mentions)..:

PS D:\Dev\Test Projects\flutter_142040> flutter build web -o docs

Target dart2js failed: ProcessException: Process exited abnormally with exit code 255:
VM initialization failed: Invalid vm isolate snapshot seen
  Command: D:\Dev\Google\Flutter\Flutter main\bin\cache\dart-sdk\bin\dart.exe compile js --platform-binaries=D:\Dev\Google\Flutter\Flutter main\bin\cache\flutter_web_sdk\kernel --invoker=flutter_tool -Ddart.vm.product=true
  -DFLUTTER_WEB_USE_SKIA=true -DFLUTTER_WEB_USE_SKWASM=false -DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/b5df29072de2778dc843a3a8ad3ffa8b2bdc885c/ --native-null-assertions --no-source-maps -o D:\Dev\Test
  Projects\flutter_142040\.dart_tool\flutter_build\064065dfa804901241659731b08efe62\app.dill --packages=D:\Dev\Test Projects\flutter_142040\.dart_tool\package_config.json --cfe-only D:\Dev\Test
  Projects\flutter_142040\.dart_tool\flutter_build\064065dfa804901241659731b08efe62\main.dart
#0      RunResult.throwException (package:flutter_tools/src/base/process.dart:118:5)
#1      _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart:344:19)
<asynchronous suspension>
#2      Dart2JSTarget.build (package:flutter_tools/src/build_system/targets/web.dart:201:5)
<asynchronous suspension>
#3      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:876:9)
<asynchronous suspension>
#4      Future.wait.<anonymous closure> (dart:async/future.dart:528:21)
<asynchronous suspension>
#5      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:814:32)
<asynchronous suspension>
#6      Future.wait.<anonymous closure> (dart:async/future.dart:528:21)
<asynchronous suspension>
#7      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:814:32)
<asynchronous suspension>
#8      FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:637:16)
<asynchronous suspension>
#9      WebBuilder.buildWeb (package:flutter_tools/src/web/compile.dart:93:34)
<asynchronous suspension>
#10     BuildWebCommand.runCommand (package:flutter_tools/src/commands/build_web.dart:253:5)

Removing the space from the Flutter SDK changes the error to this:

PS D:\Dev\Test Projects\flutter_142040> flutter build web -o docs

Target dart2js failed: ProcessException: Process exited abnormally with exit code 1:
Compile Dart to JavaScript.

Usage: dart compile js [arguments] <dart entry point>
  -h, --help      Print this usage information.
  -h -v           Show detailed information about all options.
  -o, --output    Write the output to <file name>.
  -O<0,1,2,3,4>   Set the compiler optimization level (defaults to -O1).
     -O0          No optimizations (only meant for debugging the compiler).
     -O1          Default (includes whole program analyses and inlining).
     -O2          Safe production-oriented optimizations (like minification).
     -O3          Potentially unsafe optimizations (see -h -v for details).
     -O4          More agressive unsafe optimizations (see -h -v for details).

Error: Extra arguments: Projects/flutter_142040/.dart_tool/package_config.json /D:/Dev/Test Projects/flutter_142040/.dart_tool/flutter_build/064065dfa804901241659731b08efe62/main.dart
  Command: D:\Dev\Google\Flutter\Flutter-main\bin\cache\dart-sdk\bin\dart.exe compile js --platform-binaries=D:\Dev\Google\Flutter\Flutter-main\bin\cache\flutter_web_sdk\kernel --invoker=flutter_tool -Ddart.vm.product=true
  -DFLUTTER_WEB_USE_SKIA=true -DFLUTTER_WEB_USE_SKWASM=false -DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/b5df29072de2778dc843a3a8ad3ffa8b2bdc885c/ --native-null-assertions --no-source-maps -o D:\Dev\Test
  Projects\flutter_142040\.dart_tool\flutter_build\064065dfa804901241659731b08efe62\app.dill --packages=D:\Dev\Test Projects\flutter_142040\.dart_tool\package_config.json --cfe-only D:\Dev\Test
  Projects\flutter_142040\.dart_tool\flutter_build\064065dfa804901241659731b08efe62\main.dart
#0      RunResult.throwException (package:flutter_tools/src/base/process.dart:118:5)
#1      _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart:344:19)
<asynchronous suspension>
#2      Dart2JSTarget.build (package:flutter_tools/src/build_system/targets/web.dart:201:5)

This one is because of the space in the test project. Removing that spaces resolves the issue I can build.

I deliberately have spaces in both paths because other users sometimes do - for example if their Windows username is "Firstname Lastname" and the put things in C:\Users\FirstName LastName\Documents. IMO paths should be escaped in all places to handle this.

[a-siva]

Do you still see the above error even after 08252fc was reverted

[DanTup]

@a-siva if that question was for me I was using master from yesterday:

PS D:\Dev\Google\Flutter\Flutter main> git log -1
commit b5df29072de2778dc843a3a8ad3ffa8b2bdc885c (HEAD -> master, upstream/master, upstream/main, upstream/HEAD)
Author: Jonah Williams <jonahwilliams@google.com>
Date:   Tue Jan 7 21:50:21 2025 -0800

[DanTup]

Oh, but the commit you linked was the original and not the revert. When was the revert made? (I had a search but couldn't see it)

Edit: Revert is https://dart-review.googlesource.com/c/sdk/+/401901, which was also Dec 20th, so I believe should be in Flutter master.

[a-siva]

7783e61 and 7a5174a are the reverts