Skip to content

Respect upper bound of Flutter constraint in root packages after 3.9 #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Jun 3, 2025

Solves flutter/flutter#95472 (at least partially)

By making this depend on language version we avoid a breaking change

@sigurdm sigurdm requested a review from szakarias June 3, 2025 11:54
@sigurdm
Copy link
Contributor Author

sigurdm commented Jun 3, 2025

cc @mit-mit

@sigurdm
Copy link
Contributor Author

sigurdm commented Jun 3, 2025

@mit-mit whom in the flutter world should we inform, and should we make a breaking change announcement?

@mit-mit
Copy link
Member

mit-mit commented Jun 3, 2025

Yeah, I think we should do both a flutter breaking change and dart breaking change.

Also, should we consider a flag (e.g. dart|flutter pub get --ignore-upper) for those that need the current behavoir?

@sigurdm
Copy link
Contributor Author

sigurdm commented Jun 3, 2025

Also, should we consider a flag (e.g. dart|flutter pub get --ignore-upper) for those that need the current behavior?

Probably better with an env-var. It is hard to set the flag everywhere we resolve.

Even then it might be hard - dart run or the IDE might just resolve, it is hard to set the environment or add command-line arguments for the IDE.

@mit-mit
Copy link
Member

mit-mit commented Jun 3, 2025

I don't think folks are going to need it for everyday use (the breaking change process might help us understand if that is indeed the case), so I think that a flag on get and run for the occasional CI breakage might be sufficient?

@sigurdm
Copy link
Contributor Author

sigurdm commented Jun 3, 2025

Might be.. I still prefer it as an env-var, but I can live with both...

@sigurdm sigurdm changed the title Respect upper bound of Flutter constraint in root packages Respect upper bound of Flutter constraint in root packages after 3.9 Jun 10, 2025
@sigurdm
Copy link
Contributor Author

sigurdm commented Jun 10, 2025

I realized by introducing the new interpretation based on language-version we can avoid making the change breaking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants