Proposed changes from review #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
added a commit
that referenced
this pull request
May 23, 2019
|
Thanks!
About formatting, I had to change my habits for several reasons:
I'm very sad I couldn't make the Allman PR smoothly indroduced into the core. I'm still thinking of how to achieve it smoothly, maybe file by file if I can make a script that list all modified files in unmerged-yet PRs. |
dok-net
force-pushed
the
d-a-v/recurrentscheduledfunctions
branch
from
fa749fc to
d9c2270
Compare
dok-net
commented
May 23, 2019
| } | ||
| // if no unused items, and count not too high, allocate a new one | ||
| else if (sCount < SCHEDULED_FN_MAX_COUNT) | ||
| { | ||
| result = new scheduled_fn_t; | ||
| ++sCount; | ||
| } | ||
| result->mNext = nullptr; |
There was a problem hiding this comment.
otherwise null pointer access if SCHEDULED_FN_MAX_COUNT is exhausted
dok-net
commented
May 23, 2019
| return result; | ||
| } | ||
|
|
||
| static void recycle_fn_unsafe(scheduled_fn_t* fn) | ||
| { | ||
| fn->mFunc = mFuncT(); | ||
| fn->mFunc = nullptr; // special overload in c++ std lib |
There was a problem hiding this comment.
probably for performance, so use this style instead of move assignment
dok-net
commented
May 23, 2019
| @@ -17,11 +17,13 @@ | |||
| // Note: there is no mechanism for cancelling scheduled functions. | |||
| // Keep that in mind when binding functions to objects which may have short lifetime. | |||
| // Returns false if the number of scheduled functions exceeds SCHEDULED_FN_MAX_COUNT. | |||
| //bool schedule_function(std::function<void(void)>&& fn); | |||
dok-net
commented
May 23, 2019
| bool schedule_function(const std::function<void(void)>& fn); | ||
|
|
||
| // Run given function periodically about every <repeat_us> microseconds until it returns false. | ||
| // Note that it may be more than <repeat_us> microseconds between calls if `yield` is not called | ||
| // frequently, and therefore should not be used for timing critical operations. | ||
| //bool schedule_function_us(std::function<bool(void)>&& fn, uint32_t repeat_us); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's too much to put into words, and giving you source code that compiles should be so much nicer.
What's in it:
sCount < SCHEDULED_FN_MAX_COUNT