-
Notifications
You must be signed in to change notification settings - Fork 930
docs: refactor CI setup example of GitHub Actions #4439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactor CI setup example of GitHub Actions #4439
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
permissions: | ||
contents: read | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a GitHub Actions job or workflow has no explicit permissions set, then the repository permissions are used. Repositories created under organizations inherit the organization permissions. The organizations or repositories created before February 2023 have the default permissions set to read-write. Often these permissions do not adhere to the principle of least privilege and can be reduced to read-only, leaving the write
permission only to a specific types as issues: write
or pull-requests: write
.
References
- name: Install commitlint | ||
run: npm install -D @commitlint/cli @commitlint/config-conventional | ||
- name: Print versions | ||
run: | | ||
git --version | ||
node --version | ||
npm --version | ||
npx commitlint --version | ||
- name: Install commitlint | ||
run: | | ||
npm install conventional-changelog-conventionalcommits | ||
npm install commitlint@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, move the install commitlint step for printing versions.
Second, remove conventional-changelog-conventionalcommits
because this GitHub Actions doesn't make changelog.
Finally, the command is npm install -D @commitlint/cli @commitlint/config-conventional
to match Install section.
Co-authored-by: JounQin <[email protected]>
Thanks! ❤️ |
8a295f0
into
conventional-changelog:master
…elog#4439) * docs: refactor CI setup example of GitHub Actions * docs: remove redundant double quotation Co-authored-by: JounQin <[email protected]> --------- Co-authored-by: JounQin <[email protected]>
Description
Enhancements:
Documentation:
File-Level Changes
docs/guides/ci-setup.md
docs/guides/ci-setup.md
lts/*
and npm cachingdocs/guides/ci-setup.md
docs/guides/ci-setup.md
Motivation and Context
Modernize the GitHub Actions example in the CI setup guide by simplifying Node.js and commitlint setup and updating workflow components.
Closes #4132
Usage examples
Sequence Diagram for the Updated 'commitlint' Job Steps
How Has This Been Tested?
Tested in my local repo.
Types of changes
Checklist: