Wistia widget #88
Wistia widget #88
Conversation
| @@ -0,0 +1,473 @@ | |||
| /* Contentful Widgets */ | |||
There was a problem hiding this comment.
This looks like a hard copy of cf-widget-api.css.
It would be more intuitive if you would just reference it or let a task to build the widget copy it. Check out some of the other examples for inspiration :)
|
@DanweDE Done! @zeusdeux @geigerzaehler would be great if someone could have a look! |
|
Could you add the example to the main readme? |
|
|
||
| - Start a local server (replace your port if needed) | ||
| ```bash | ||
| python -m SimpleHTTPServer 3030 |
There was a problem hiding this comment.
There is a npm run widget:serve task if I’m not mistaken. So do we really need this?
There was a problem hiding this comment.
Good point. I will remove the widget:serve as it is not working correctly with the html plugin I use with webpack.
| onValueChanged() { | ||
|
|
||
| if (this.widgetApi && this.inputEl) { | ||
| console.log(this.widgetApi.field.getValue()); |
There was a problem hiding this comment.
Is this a debugging artefact?
| this.widgetApi.field.onValueChanged(this.onValueChanged.bind(this)); | ||
|
|
||
| // Resize iframe in Contenful UI. | ||
| this.widgetApi.window.updateHeight(); |
There was a problem hiding this comment.
Remove this method and make it part of the constructor. This way we can always assume that this.widgetApi is set and remove some checks.
|
LGTM. Please squash before merging |
Initial commit of the wistia example widget.