Skip to content

Travis CI integration #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2016
Merged

Travis CI integration #60

merged 2 commits into from
Nov 9, 2016

Conversation

edenhill
Copy link
Contributor

@edenhill edenhill commented Nov 8, 2016

No description provided.

@ewencp
Copy link
Contributor

ewencp commented Nov 8, 2016

LGTM. The one caveat is that we may eventually need to use a prerelease version of librdkafka as we've done previously. The bootstrap-librdkafka script looks like it might eventually need to be upgraded. (In particular, if we want to test against the combo of stuff that will ultimately be released.) Then again, maybe that'll just turn into a larger matrix of librdkafka x confluent-kafka-python versions anyway, and extra branches from git for librdkafka may just be a special case.

@edenhill
Copy link
Contributor Author

edenhill commented Nov 9, 2016

You are right, but let's tackle that when we get there.
I wanted to keep it off master to avoid PR runs to fail just because of librdkafka master regression.

@edenhill edenhill merged commit 745b6f3 into master Nov 9, 2016
@edenhill edenhill deleted the travis branch November 9, 2016 12:33
@odemkovych odemkovych mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ewencp ewencp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edenhill @ewencp