-
Notifications
You must be signed in to change notification settings - Fork 916
Add producer purge method with optional blocking argument #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edenhill
merged 14 commits into
confluentinc:master
from
peteryin21:add_purge_to_producer
Oct 20, 2020
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8dbc229
add producer purge method with optional blocking argument
c8a7bb2
Add PurgeStrategy enum exposing purge flags and add as required argum…
e0be387
Add error handling for Producer_purge
8dcad18
misc fixes to errors and warnings when building
13e3636
address comments, remove enum and make each option a bool
71caead
This bug took way too long to figure out
07999b1
fix another typo in purge kw list
8b585b1
add test for purge in test_Producer.py
4880862
minor doc change
1cce53c
move declaration of purge strategy variable to top
a1d4ec6
Really python2? You don't understand underscores in numbers? Psh
55eaa4f
python2 doesn't have the nonlocal keyword either
273ec69
python2 doesn't have 'p' format char
b1ffd0e
address comments from review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the source is messed up tab/space-wise, but please try to use 8-space indents in new code, no tabs.
Thank you!