Skip to content

When caching schemas, ensure the cache key matches the input #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

When caching schemas, ensure the cache key matches the input #1922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/confluent_kafka/schema_registry/schema_registry_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def set_schema(self, subject: str, schema_id: int, schema: 'Schema'):
self.schema_id_index[subject][schema_id] = schema
self.schema_index[subject][schema] = schema_id

def set_registered_schema(self, registered_schema: 'RegisteredSchema'):
def set_registered_schema(self, schema: 'Schema', registered_schema: 'RegisteredSchema'):
"""
Add a RegisteredSchema to the cache.

Expand All @@ -484,7 +484,6 @@ def set_registered_schema(self, registered_schema: 'RegisteredSchema'):
subject = registered_schema.subject
schema_id = registered_schema.schema_id
version = registered_schema.version
schema = registered_schema.schema
with self.lock:
self.schema_id_index[subject][schema_id] = schema
self.schema_index[subject][schema] = schema_id
Expand Down Expand Up @@ -786,7 +785,7 @@ def register_schema_full_response(

registered_schema = RegisteredSchema.from_dict(response)

self._cache.set_schema(subject_name, registered_schema.schema_id, registered_schema.schema)
self._cache.set_schema(subject_name, registered_schema.schema_id, schema)

return registered_schema

Expand Down Expand Up @@ -866,7 +865,7 @@ def lookup_schema(

registered_schema = RegisteredSchema.from_dict(response)

self._cache.set_registered_schema(registered_schema)
self._cache.set_registered_schema(schema, registered_schema)

return registered_schema

Expand Down Expand Up @@ -1025,7 +1024,7 @@ def get_version(

registered_schema = RegisteredSchema.from_dict(response)

self._cache.set_registered_schema(registered_schema)
self._cache.set_registered_schema(registered_schema.schema, registered_schema)

return registered_schema

Expand Down