Add node for forcing tiled VAE encode #7924
Open
+40
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ComfyUI with Radeon + ROCm + WSL (and possibly other use cases) VAE encode/decode typically always results in OOM and reverts to the tiled version. There is already beta nodes for tiled VAE encode/decode, however some nodes has the VAE encoding "baked in" (e.g. I2V WAN node), thus leaving no options other than waiting for the OOM when encoding VAE.
This pull request adds a subclass to VAE class that overrides encode method with the tiled version, along with a node that will cast a given VAE to the tiled VAE version with desired tiled dimensions. Putting this node after the load VAE node will resolve the issue of having to wait for OOM when encoding VAE.