Deactivate H2O tests on 0.5 GB #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
force-pushed
the
big-not-small-data
branch
from
bd1e166 to
2862003
Compare
fjetter
approved these changes
Oct 20, 2023
fjetter
suggested changes
Oct 20, 2023
| @@ -31,8 +31,6 @@ | |||
| raise ValueError("Unknown h2o dataset(s): ", unknown_datasets) | |||
| else: | |||
| enabled_datasets = { | |||
| "0.5 GB (csv)", | |||
There was a problem hiding this comment.
Do we have any other CSV tests? While I don't care deeply about this, I would care if this was 100% slower
There was a problem hiding this comment.
There's test_csv.py::test_csv_basic. If we want something more integrated, I'd rather include 5 GB (csv). 0.5 GB just doesn't make any sense for dask.
There was a problem hiding this comment.
test_csv_basic works for me. I just would like to get notified if we're significantly slower all of a sudden
fjetter
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.