Skip to content

Remove AcceptOrigins and add AcceptInsecureOrigin #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Remove AcceptOrigins and add AcceptInsecureOrigin #55

merged 3 commits into from
Apr 16, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Apr 16, 2019

Closes #39

nhooyr added 3 commits April 15, 2019 13:35
- Make messageReader a value type to avoid allocation
- Add a bunch of important TODOs
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #55 into master will increase coverage by <.01%.
The diff coverage is 70.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   77.11%   77.12%   +<.01%     
==========================================
  Files          11       11              
  Lines         673      682       +9     
==========================================
+ Hits          519      526       +7     
- Misses        128      130       +2     
  Partials       26       26
Impacted Files Coverage Δ
messagetype_string.go 0% <0%> (ø)
json.go 56.25% <50%> (ø) ⬆️
websocket.go 78.73% <88.88%> (+0.04%) ⬆️
accept.go 87.23% <93.33%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932d16d...696af24. Read the comment docs.

@nhooyr nhooyr merged commit d67546a into master Apr 16, 2019
@nhooyr nhooyr deleted the better branch April 16, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm AcceptOrigins API
1 participant