[3.9.3][Mac] Search errors out with ENOENT

[heathen711]

OS/Web Information

• Web Browser: Safari
• Local OS: MacOS 11.3
• Remote OS: MacOS 10.15.17
• Remote Architecture: x64
• code-server --version: 3.9.3 fe2dc2d

Steps to Reproduce

1. Open project
2. Search
3. Try to search for something in the project
4. Get ENOENT error

Expected

Search to produce results

Actual

Error message (see screenshot)

Screenshot

Notes

> stat ~/.local/lib/code-server-3.9.3/lib/vscode/node_modules/vscode-ripgrep 
16777224 213605904 drwxr-xr-x 10 local staff 0 320 "Apr 12 13:59:51 2021" "Apr  8 11:32:45 2021" "Apr 12 13:59:54 2021" "Apr  8 11:32:45 2021" 4096 0 0 /Users/local/.local/lib/code-server-3.9.3/lib/vscode/node_modules/vscode-ripgrep

> ls ~/.local/lib/code-server-3.9.3/lib/vscode/node_modules/vscode-ripgrep/bin 
<nothing there>

I deleted the entire code-server install and re-installed and the issue persisted:

> curl -fsSL https://code-server.dev/install.sh | sh
macOS v10.15.7
Homebrew not installed.
Installing standalone release archive v3.9.3 from GitHub releases.

+ Reusing ~/.cache/code-server/code-server-3.9.3-macos-amd64.tar.gz
+ mkdir -p ~/.local/lib ~/.local/bin
+ tar -C ~/.local/lib -xzf ~/.cache/code-server/code-server-3.9.3-macos-amd64.tar.gz
+ mv -f ~/.local/lib/code-server-3.9.3-macos-amd64 ~/.local/lib/code-server-3.9.3
+ ln -fs ~/.local/lib/code-server-3.9.3/bin/code-server ~/.local/bin/code-server

Standalone release has been installed into ~/.local/lib/code-server-3.9.3
Please extend your path to use code-server:
  PATH="$HOME/.local/bin:$PATH"
Then you can run:
  code-server

This issue can be reproduced in VS Code: No

I found other people reporting this but its suppose to be fixed now so reporting it again:
#1907
#1683

[jsjoeio]

Unfortunately, I cannot reproduce locally using macOS + Safari + 3.9.3

Demo

Screen.Recording.2021-04-12.at.2.33.30.PM.mov

Though I do think I could have installed ripgrep separately outside of code-server hence why. Not sure if that could be affecting this.

Please extend your path to use code-server:
PATH="$HOME/.local/bin:$PATH"

Did you do this?

And if you install ripgrep with brew install ripgrep and then run code-server, do you still get the same issue?

[heathen711]

Just for good measure I deleted the cache'd installer and install to ensure the script downloaded the latest.

> rm ~/.cache/code-server/code-server-3.9.*         
> rm -rf ./.local/lib/code-server-3.9.3 
> curl -fsSL https://code-server.dev/install.sh | sh
macOS v10.15.7
Homebrew not installed.
Installing standalone release archive v3.9.3 from GitHub releases.

+ mkdir -p ~/.cache/code-server
+ curl -#fL -o ~/.cache/code-server/code-server-3.9.3-macos-amd64.tar.gz.incomplete -C - https://github.com/cdr/code-server/releases/download/v3.9.3/code-server-3.9.3-macos-amd64.tar.gz
######################################################################## 100.0%
+ mv ~/.cache/code-server/code-server-3.9.3-macos-amd64.tar.gz.incomplete ~/.cache/code-server/code-server-3.9.3-macos-amd64.tar.gz
+ mkdir -p ~/.local/lib ~/.local/bin
+ tar -C ~/.local/lib -xzf ~/.cache/code-server/code-server-3.9.3-macos-amd64.tar.gz
+ mv -f ~/.local/lib/code-server-3.9.3-macos-amd64 ~/.local/lib/code-server-3.9.3
+ ln -fs ~/.local/lib/code-server-3.9.3/bin/code-server ~/.local/bin/code-server

Standalone release has been installed into ~/.local/lib/code-server-3.9.3
Please extend your path to use code-server:
  PATH="$HOME/.local/bin:$PATH"
Then you can run:
  code-server
> ls ~/.local/lib/code-server-3.9.3/lib/vscode/node_modules/vscode-ripgrep/bin
> stat ~/.local/lib/code-server-3.9.3/lib/vscode/node_modules/vscode-ripgrep  
16777224 213613414 drwxr-xr-x 10 local staff 0 320 "Apr 12 14:34:51 2021" "Apr  8 11:32:45 2021" "Apr 12 14:34:54 2021" "Apr  8 11:32:45 2021" 4096 0 0 /Users/local/.local/lib/code-server-3.9.3/lib/vscode/node_modules/vscode-ripgrep
> code-server --version
3.9.3 fe2dc2deb08e378069891b622bb62ad1d261d1b1

My path is updated:
/Users/local/.local/bin:/Users/local/Library/Python/3.8/bin:/Library/Frameworks/Python.framework...

I don't have brew installed (and frankly don't want to install it as brew messes with other things).

I've never install ripgrep in any way manually.

[jsjoeio]

I don't have brew installed (and frankly don't want to install it as brew messes with other things).

No worries then! Just an idea.

I've never install ripgrep in any way manually.

Yeah I don't think you should have to. Let me try this:

1. Uninstall ripgrep and code-server
2. Reinstall 3.9.3
3. Test

[jsjoeio]

Hmm...still not able to reproduce. But when the script runs, it's installing it via homebrew for me so I guess the repro isn't 1:1 🤔

Demo

Screen.Recording.2021-04-12.at.2.45.29.PM.mov

Hmm...I'm guessing you tried this too?

Something that might work to fix it would be to try running yarn in the vscode-ripgrep directory and see if it downloads rg.

From comment

@code-asher any thoughts on why this might be happening?

[code-asher]

Ah this has happened before actually. Ripgrep fails to download so code-server gets packaged up without it.

Ideally yarn install should fail when that happens but for whatever reason it doesn't.

[code-asher]

Here's the failure: https://github.com/cdr/code-server/runs/2299634815?check_suite_focus=true#step:7:50

[jsjoeio]

Wow! Nice find 🙌 Would not have thought to look there.

A few follow-ups then:

1. What workaround can we suggest for @heathen711?
2. How can we prevent this from slipping through the release in the future?

Ideas:

• add a step to build-standalone-release.sh that checks for ripgrep and fails if not present
• add a step to test-standalone-release.sh that checks for ripgrep and fails if not present
• add e2e test for searching through files (good to have, but wouldn't solve this issue)

[code-asher]

An e2e test for searching would be excellent. But I think testing for the existence of the binary is a good workaround until we do that.

Related: #2651

For working around this issue the easiest thing I can think of aside from downgrading is:

cd ~/.local/lib/code-server-3.9.3
rm -r ./lib/vscode/node_modules/vscode-ripgrep/bin
./lib/node ./lib/vscode/node_modules/vscode-ripgrep/lib/postinstall.js

That will run the postinstall script that downloads ripgrep.