This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Run NodeCG test in CI on Windows #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that nodecg-io is loadable on Windows automatically by CI.
We already have this for Linux as of #327, this PR just makes it compatible with Windows and runs it in CI.
The timeout command returns a non-negative exit code for some reason when the timeout is reached so I've ditched it and implemented the timeout in the node.js script.
The test with windows is pretty slow in CI so I've at least cached the NodeCG installation making it (more or less) acceptable.