This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Add config presets #249
Merged
Add config presets #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a great feature! |
hlxid
changed the title
Also fixes various typos in the serial port client and json schema.
Removes previous discover feature of the Hue service because device presets allow for selection between multiple bridges in a nice gui. Uses the same N-UPnP discovery from the underlying Hue library as the discover feature did.
|
I've added presets to the Hue service with 2cac598 and removed the old discover feature. Would be nice if someone could test whether this works because I don't own a Hue bridge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109
Currently has presets for
I might add more services to this list, still looking checking presets really make sense.
With this change we also need to update the documentation to include the feature in the affected services and maybe add a extra page explaining the feature. Also
discoverfrom Hue has been removed and also needs to be removed from the docs.How it works:
2021-08-28.11-16-11.mp4
The preset drop-down is only visible if the service provides presets and is hidden for services that don't provide any otherwise the UI would be too cluttered.