This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Don't lint generated typescript declaration files #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlxid
added
minor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ESLint lints
.tsfiles, including.d.tsfiles. This is a problem because each .ts file will generate a .d.ts file since #228. These generated files don't pass the linter because of that you currently have linting errors if you have built the project before linting. The linting action obviously wasn't affected by this because it doesn't build the project.To fix this we need to disable linting of .d.ts files and migrate our currently manually created
.d.tsfiles into.tsfiles so that they still get linted. Both of these steps are done in this PR.