-
Notifications
You must be signed in to change notification settings - Fork 26
SQL service #237
SQL service #237
Conversation
Still contains a reference to mysql in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove nodecg-io-sql/package-lock.json
. It is created when using e.g. npm install sqlite3
inside the sql service. Add your dependencies manually to the corresponding package.json
file and the run npm run bs
in the repository root (this also needs to be done to update the root package-lock.jn
)
If you will add a explanation to the docs on how to install support for other sql dialects please use npm install sqlite3 --no-save
. This will create no lockfile because for when a user manually installs a dependency these are not really required anyway.
I don't really care whether we want to include mysql by default. On the one hand it makes it easier to get started, on the other we could make the installation smaller for people not using mysql. I'm fine with both, do want you think is better. We still can change it after merging this PR.
Adds docs for codeoverflow-org/nodecg-io#237.
Close #223 by using knex with mysql as default client. Can be used with any other supported client, though.
Progress: