Skip to content

Copy the latest Vagrantfile.dist in CodeIgniter4 repository #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2022
Merged

Copy the latest Vagrantfile.dist in CodeIgniter4 repository #38

merged 4 commits into from
Jul 30, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 29, 2022

But it seems it does not work.
See codeigniter4/CodeIgniter4#2453

This was referenced Jul 29, 2022
Merged
Closed
@kenjis kenjis force-pushed the update-Vagrantfile.dist branch from a1871ca to d9e7811 Compare July 29, 2022 22:19
MGatner
MGatner approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me that the issue reported on the framework was actually a port collision from some other service/instance, and not a problem with the Vagrant Config itself.

@kenjis
Copy link
Member Author

kenjis commented Jul 30, 2022

Exactly. I changed the Note a bit. b9e67ea

@kenjis kenjis merged commit c802432 into codeigniter4:develop Jul 30, 2022
@kenjis kenjis deleted the update-Vagrantfile.dist branch July 30, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner