Skip to content

Rector Version #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Rector Version #125

merged 2 commits into from
Feb 22, 2024

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Feb 22, 2024

Description

  • Expands Rector version to be backwards-compatible to 0.19
  • Normalizes the Composer config

@samsonasik
Copy link
Member

I prefer the bump of using 1.0.0 tbh, with reasons:

  • there is no bc break on 0.19 vs 1.0.0 afaik
  • rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

@MGatner
Copy link
Member Author

MGatner commented Feb 22, 2024

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

@MGatner
Copy link
Member Author

MGatner commented Feb 22, 2024

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

@MGatner MGatner merged commit 78caaaf into develop Feb 22, 2024
@MGatner MGatner deleted the rector-version branch February 22, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants