Skip to content

chore: fix psalm error on 4.7 #9590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

chore: fix psalm error on 4.7 #9590

merged 1 commit into from
Jun 1, 2025

Conversation

paulbalandan
Copy link
Member

Description
I cannot reproduce the psalm error on my local 4.7 branch. So testing here.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

michalsn
michalsn approved these changes May 31, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was very strange because I also could not reproduce it locally. Thanks!

@paulbalandan paulbalandan merged commit 3f2a434 into codeigniter4:4.7 Jun 1, 2025
8 checks passed
@paulbalandan paulbalandan deleted the fix-psalm-crash branch June 1, 2025 01:48
paulbalandan added a commit that referenced this pull request Jun 3, 2025
@paulbalandan
chore: fix psalm error on 4.7 (#9590)
a19b44c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @michalsn