Added vendor/project namespace, restructured folders for PSR-4 #58
Conversation
This is set via the web UI now.
|
@hollodotme I tried to enable the phpcodesniffer engine on this repo and encountered a slew of issues for tabs that should be spaces, which it looks like was a change you made. Do you strongly prefer tabs / is there something about PSR-4 that requires it? If not, I'm going to go ahead and put them all back to spaces (and clean up some other formatting issues) so I can enable phpcodesniffer. |
|
@pbrisbin No, there is generally no requirement for tabs in the PSR standards or elsewhere. I prefer tabs because they have no semantic meaning, while spaces do. Btw, afaik it is a setting in the codesniffer if it should check for tabs or spaces. As mentioned, my PhpStorm default formatting rules apply tabs when formatting code. Anyway, it's your code, you choose. ;) |
|
Thank you. I've changed three style things as identified by phpcodesniffer:
In all cases we pefer it this way, and it happens to be phpcodesniffer's defaults, so that's nice. I apologize if this makes rebasing your other branches more difficult. |
|
Really, no problem. |
| enabled: true | ||
| config: | ||
| languages: | ||
| - ruby |
There was a problem hiding this comment.
Nit, but can we clean this file up a bit? I don't think we need all the duplication language, nor do we need ratings paths for *.js, etc.
There was a problem hiding this comment.
Strange. I didn't even look after I initd. I wonder why this was added.
There was a problem hiding this comment.
I think all of those extensions get added because they're all potentially analyzeable by the duplication engine. We should make that smarter ;)
There was a problem hiding this comment.
I wonder why this was added.
Because our init code isn't that smart 😀. We see some regexes for some languages duplication supports, so we enable the engine with a default config, but don't tailor that config to which regexes matched.
|
LGTM |
| * @see \Symfony\Component\Console\Application::getDefaultCommands() | ||
| */ | ||
| protected function getDefaultCommands() | ||
| { | ||
| // Keep the core default commands to have the HelpCommand | ||
| // which is used when using the --help option | ||
| $defaultCommands = parent::getDefaultCommands(); | ||
| $defaultCommands = parent::getDefaultCommands(); |
There was a problem hiding this comment.
It looks like aligned tokens are actually the expected style here.
- `(arg)`, not `( arg )`
- `if {`, not `if\n{`
This includes #55 and is where I plan to configure CC platform and make any
other fixes before moving on that track.
/cc @hollodotme