Skip to content

Updating 'satooshi/php-coveralls' to use version 1.0.* #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2016
Merged

Updating 'satooshi/php-coveralls' to use version 1.0.* #45

merged 2 commits into from
Feb 16, 2016

Conversation

ericdowell
Copy link
Contributor

Updating satooshi/php-coveralls to version 1.0.*.

This involves:

  • Changing reference from Contrib\\ to new namespace Satooshi\\. (issue: https://github.com/satooshi/php-coveralls/issues/38)
  • Changing setSrcDir to setRootDir method on Configuration class since setSrcDir has been removed. (issue https://github.com/satooshi/php-coveralls/issues/126)

Original PR: #44

Branch name better describes purpose of PR.

This involves changing reference from 'Contrib\\' to new namespace, 'Satooshi\\' and changing 'setSrcDir' to 'setRootDir' method on 'Configuration' class since 'setSrcDir' has been removed.
@ericdowell ericdowell mentioned this pull request Feb 2, 2016
@msvrtan
Copy link

msvrtan commented Feb 13, 2016

+1

1 similar comment
@kevinkhill
Copy link

+1

@gdiggs
Copy link
Contributor

gdiggs commented Feb 16, 2016

Thank you!

gdiggs added a commit that referenced this pull request Feb 16, 2016
Updating 'satooshi/php-coveralls' to use version 1.0.*
@gdiggs gdiggs merged commit 770e5a2 into codeclimate:master Feb 16, 2016
@ericdowell ericdowell deleted the update-php-coveralls branch February 16, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants