Fix: Travis configuration #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
changed the title
|
Closing due to staleness. |
|
@localheinz Can you tell me more about what you're trying to fix with this pull? |
| @@ -1,12 +1,30 @@ | |||
| language: php | |||
|
|
|||
| sudo: false | |||
There was a problem hiding this comment.
This sends builds to container-based infrastructure, see Using container-based infrastructure:
Jobs running on container-based infrastructure:
- start up faster
- allow the use of caches for public repositories
- disallow the use of sudo, setuid and setgid executables
|
👍 |
|
LGTM @localheinz Would you mind rebasing to a single commit and summarizing your updates in the commit message? |
* add some vertical whitespace * update composer itself in before_install section * remove --dev flag when installing dependencies with Composer as it is the default * explicitly send builds to container-based infrastructure * enable caching of dependencies as installed with Composer * use phpunit as installed with Composer
|
Done! |
|
@localheinz Thanks for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
.travis.ymlfor enhanced legibilitybefore_installsection--devflag as development dependencies are installed by defaultphpunitas installed with dependenciesSomewhat related to #30.