Media upload and message support #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: |
jeffyanta
reviewed
Jan 22, 2025
proto/blob/v1/blob_service.proto
Outdated
| message UploadRequest { | ||
| common.v1.UserId owner_id = 1; | ||
| BlobType blob_type = 2; | ||
| bytes raw_data = 3; |
There was a problem hiding this comment.
Note that max gRPC message size is 4MB
There was a problem hiding this comment.
Honestly, that is probably fine for the non-chunked flow. I don't think we should increase that. Also, clients should probably add some kind of compression on their end as well to reduce network latency to the server.
| @@ -0,0 +1,39 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
In general, I think everything looks good. Probably just need to add proto validation to the applicable fields.
zfedoran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeffyanta take a look and let me know if you would make any changes here.
I threw in audio/video just to try to get a feel for what it might require if we ever go down those paths. Not going to implement those now.
Roughly chasing after this:
