Design and enforce linting standards

[krivard]

https://github.com/cmu-delphi/covidcast-indicators has nice linting requirements (here is an example pylint file), and we deserve nice things over here too.

To do it the same way that indicators does, we'd need to either figure out how to lint a mixed tree of python files or convert acquisition and server to actual legit python modules. Then we just add pylint commands to CI.

We don't have to do it the same way that indicators does though. Alternatives?

[dshemetov]

Looking at the pylint docs, it looks like they really leave you on your own when your files aren't packaged. This somewhat hacky solution might just get the job done though. Can't really think of serious downsides.

[dshemetov]

I'll also throw out that I'm pretty partial to black.

The biggest selling point for me is the time-saving: often the solution to pylint's complaints are deterministic (delete trailing white spaces, break long lines, etc.) and black can just do that automatically.

To be fair, sometimes it really struggles and removes clearly human-readable formatting. But I think most of those can be mitigated by a judicious use of the fmt flag or by refactoring long call chains to variables.

[melange396]

for posterity, the above-referenced mention is here: #1041 (comment)

[dshemetov]

Formatting work

• acquisition - style(black): format acquisition with black, line-length=100 #1189
• acquisition - covid_hosp
• acquisition - covidcast
• clients
• server
• tests
• integration