Skip to content

Revert "Boost - update to 1.75.0" #6698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Revert "Boost - update to 1.75.0" #6698

merged 1 commit into from
Mar 4, 2021

Conversation

smuzaffar
Copy link
Contributor

Reverts #6655

need more testing on aarch64 where it is failing all relvals with errors like

----- Begin Fatal Exception 04-Mar-2021 02:04:40 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named MinBias_8TeV_pythia8_TuneCUETP8M1_cff_GEN_SIM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: boost::filesystem::status: Function not implemented: "/build/cmsbld/jenkins_c/workspace/ib-run-relvals/CMSSW_11_3_X_2021-03-03-2300/poison/SimTracker/SiStripDigitizer/data/APVShapePeak_default.txt"

At:
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Types.py(835): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Mixins.py(377): insertContentsInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Types.py(920): insertContentsInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Types.py(913): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Mixins.py(377): insertContentsInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Types.py(920): insertContentsInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Types.py(913): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Config.py(1092): _insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_aarch64_gcc9/cms/cmssw-patch/CMSSW_11_3_X_2021-03-03-2300/python/FWCore/ParameterSet/Config.py(1306): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

@smuzaffar smuzaffar merged commit 5a43693 into IB/CMSSW_11_3_X/master Mar 4, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@smuzaffar
Copy link
Contributor Author

Yes it is FileInPath but at https://github.com/cms-sw/cmssw/blob/master/FWCore/ParameterSet/src/FileInPath.cc#L89 . Looks like now bf::exists(p) throws exception if file does not exist but this is only happening for aarch64 . for amd64 and ppc64le, it is not throwing exception

@smuzaffar
Copy link
Contributor Author

boost code in question is
https://github.com/cms-externals/boost/blob/cms/v1.75.0/libs/filesystem/src/operations.cpp#L2571
https://github.com/cms-externals/boost/blob/cms/v1.72.0/libs/filesystem/src/operations.cpp#L1693

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@smuzaffar
Copy link
Contributor Author

boost build log for aarch64 is https://cmssdt.cern.ch/SDT/jenkins-artifacts/build-any-ib/CMSSW_11_3_X_2021-03-02-1100/slc7_aarch64_gcc9/106005/external/boost/1.75.0-692eebc1b36f0139611ad4f3eddf0ca8/

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@smuzaffar
Copy link
Contributor Author

I am not 100% sure. A simple test[a] on aarch64 with boost 1.75 also fails even if I set -DBOOST_FILESYSTEM_HAS_STATX_SYSCALL

[a]

#include <iostream>
#include <string>
#include "boost/filesystem/path.hpp"
#include "boost/filesystem/operations.hpp"
namespace bf = boost::filesystem;
#include <sys/stat.h>
int main()
{
  std::string p("/build/cmsbld/x/p/CMSSW_11_3_X_2021-03-03-2300/poison/FWCore/ParameterSet/python/Config.py");
  struct ::stat path_stat;
  int err = ::stat(p.c_str(), &path_stat);
  std::cout<<err<<std::endl;
  if (!bf::exists(p))
    std::cout <<"ok"<<std::endl;
  return 0;
}

@smuzaffar
Copy link
Contributor Author

let me try to build on the 2nd aarch64 node , may be boost was built on the other node

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Mar 4, 2021 •
edited
Loading

yup looks like issue is with boost built on one system and running it on other.

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@smuzaffar smuzaffar mentioned this pull request Mar 4, 2021
Merged
@davidlange6
Copy link
Contributor

cms-sw/cmssw#33066

@smuzaffar smuzaffar mentioned this pull request Mar 4, 2021
Merged
@smuzaffar
Copy link
Contributor Author

thanks @davidlange6 , #6699 is not testing boost 1.75 and cms-sw/cmssw#33066

@smuzaffar smuzaffar deleted the revert-6655-update-boost-175 branch March 10, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smuzaffar @cmsbuild @davidlange6