Move builtin classmethod_descriptor to a different test #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch mvoes the builtin classmethod descriptor test to a different one and mark it to skip for python >= 3.10.8. The classmethod descriptor serializarion was removed from python in these releases: https://docs.python.org/3.10/whatsnew/changelog.html#id3 More information in the github issue: python/cpython#95196 Fix cloudpipe#485
Codecov ReportBase: 92.47% // Head: 83.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 92.47% 83.12% -9.36%
==========================================
Files 4 3 -1
Lines 718 711 -7
Branches 159 153 -6
==========================================
- Hits 664 591 -73
- Misses 33 89 +56
- Partials 21 31 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ogrisel
approved these changes
Oct 28, 2022
|
There are unrelated failures with the pytest module... |
Co-authored-by: Pierre Glaser <[email protected]>
Co-authored-by: Pierre Glaser <[email protected]>
Co-authored-by: Pierre Glaser <[email protected]>
|
Thanks @danigm, waiting for CI and merging. |
|
Let's merge and fix the CI in #494. |
This was referenced Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch mvoes the builtin classmethod descriptor test to a different one and mark it to skip for python >= 3.10.8. The classmethod descriptor serializarion was removed from python in these releases: https://docs.python.org/3.10/whatsnew/changelog.html#id3
More information in the github issue:
python/cpython#95196
Fix #485