Skip to content

Update gg2fig as gg2list #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2015
Merged

Update gg2fig as gg2list #1

merged 1 commit into from
May 4, 2015

Conversation

mkcor
Copy link

@mkcor mkcor commented May 4, 2015

Following plotly/plotly.R#210

I thought I would make this change as invisible as possible... Because gg2fig has been communicated about already... Otherwise we should replace all these instances of gg2fig by gg2list:

marianne@marianne-thinkpad:~/plotly/plotly-shiny(master)$ ack gg2fig
What_You_Need/plotlyGraphWidget.R
18:gg2fig <- function(gg) {

What_You_Need/server_Template_GGPLOT.R
17: gg<- gg2fig(YOUR_PLOT)

Examples/UN_Advanced/plotlyGraphWidget.R
18:gg2fig <- function(gg) {

Examples/UN_Advanced/server.R
46:      gg<- gg2fig(ggideal_point)

Examples/Diamonds/plotlyGraphWidget.R
18:gg2fig <- function(gg) {

Examples/Diamonds/server.R
27:     gg <- gg2fig(p)

Examples/UN_Simple/plotlyGraphWidget.R
18:gg2fig <- function(gg) {

Examples/UN_Simple/server.R
26:      gg<- gg2fig(ggideal_point)

Examples/Movies/plotlyGraphWidget.R
18:gg2fig <- function(gg) {

/cc @cldougl @chriddyp

cldougl added a commit that referenced this pull request May 4, 2015
Update gg2fig as gg2list
@cldougl cldougl merged commit c0fb114 into cldougl:master May 4, 2015
@mkcor mkcor deleted the patch-1 branch May 4, 2015 22:08
@chriddyp
Copy link

chriddyp commented May 4, 2015

@mkcor can you make another PR into chriddyp/plotly-shiny? that's the "official" one, linked from plotly's site

Sent from my iPhone

On May 4, 2015, at 5:52 PM, Chelsea [email protected] wrote:

Merged #1.


Reply to this email directly or view it on GitHub.

@cldougl
Copy link
Owner

cldougl commented May 5, 2015

@chriddyp @mkcor I updated the examples and sent a PR to chriddyp/plotly-shiny

@mkcor
Copy link
Author

mkcor commented May 5, 2015

Thank you so much, @cldougl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants