Simd.js: Removing Float32x4 MinNum and MaxNum builtins. #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikeHolman @abchatra please review. |
|
|
|
@abchatra can you please sign off the PR too. Thanks! |
See tc39/ecmascript_simd#341 MinNum and MaxNum operations are decided to be removed from Simd.js as they are incompatablie with IEE-754 definitions of MinNum and MaxNum, which makes use of quiet NaN's and signaling NaN's.
chakrabot
pushed a commit
that referenced
this pull request
May 26, 2016
Merge pull request #1030 from arunetm:RmF4MinMaxNum See tc39/ecmascript_simd#341 MinNum and MaxNum operations are decided to be removed from Simd.js as they are incompatablie with IEE-754 definitions of MinNum and MaxNum, which makes use of quiet NaN's and signaling NaN's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/ecmascript_simd#341
MinNum and MaxNum operations are decided to be removed from
Simd.js as they are incompatablie with IEE-754 definitions of
MinNum and MaxNum, which makes use of quiet NaN's and signaling NaN's.