forked from usnistgov/CASE-Utilities-Python
-
Notifications
You must be signed in to change notification settings - Fork 3
Add inherence UUID functions #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f class's IRI While drafting hand-written example data, it had proved beneficial to some drafters (myself included) to disambiguate `owl:NamedIndividual`s from `owl:Class`es by spelling the class differently in the IRI. Taking `uco-observable:FileFacet` as an example, it was originally frequently written as `FileFacet` when referring to the class, and `file-facet-...` when referring to an individual. Unfortunately, trying to carry this pattern forward is likely to create a technological burden. Camel casing can't always be assumed to apply straightforwardly, and would cause special-case logic to be needed. See e.g.: * `uco-observable:WifiAddressFacet` that would split on capital letters to `kb:wifi-address-facet`, which doesn't seem to be a problem; * `uco-location:GPSCoordinatesFacet` would induce `kb:g-p-s-coordinates-facet`, which seems far less obviously acceptable; * `uco-observable:HTTPConnectionFacet` splitting to `kb:h-t-t-p-connection-facet` may be the last convincing we need. Rather than invest in preserving the lowercased, hyphenated suffix scheme, this patch removes the question and now has individuals use the last path-segment of the class's IRI. A follow-on patch will regenerate Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
This patch enables review of Python code inlined in the `case-utils` modules' docstrings. An initial docstring test is also included, because `pytest` reports an error if it is called and no tests are found. References: * https://docs.pytest.org/en/7.1.x/how-to/doctest.html Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
… case_file A follow-on patch will regenerate Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
The summary of this PR is:
|
Discussed and approved in the 2023-05-09 Adoption Committee meeting |
ajnelson-nist
added a commit
to casework/CASE-Implementation-ExifTool
that referenced
this pull request
May 11, 2023
A follow-on patch will regenerate Make-managed files. References: * casework/CASE-Utilities-Python#112 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Implementation-ExifTool
that referenced
this pull request
May 11, 2023
References: * casework/CASE-Utilities-Python#112 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Implementation-PyPI-Exifread
that referenced
this pull request
May 11, 2023
Rationale is documented in case-utils PR 112. References: * casework/CASE-Utilities-Python#112 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Implementation-PyPI-Exifread
that referenced
this pull request
May 11, 2023
Rationale is documented in case-utils PR 112. References: * casework/CASE-Utilities-Python#112 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Implementation-PyPI-Exifread
that referenced
this pull request
May 11, 2023
Rationale is documented in case-utils PR 112. References: * casework/CASE-Utilities-Python#112 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Implementation-PROV-O
that referenced
this pull request
May 18, 2023
…nodes This patch uses the inherence UUID functions from `case-utils` PR 112 to replace the blank nodes generared with SPARQL Construct queries. As side effects of this migration, some bugs were fixed with generating some associations, and inherence modeling assumptions are now specified in code comments. This patch also adds `prov:Start` and `prov:End` nodes to reify `prov:Activity` (and `case-investigation:InvestigativeAction`) time boundaries. This will be a significant assistance in OWL-Time-based visualization under development for `case-prov` PR 54. Creating the `prov:Start` and `prov:End` nodes as IRI-identified is also necessary because of a bug observed in `rdf-toolkit`; see their Issue 52. Since `case_prov_rdf` will now be able to generate non-blank nodes, it has picked up two behaviors used in other projects importing `case-utils`: * The `--use-deterministic-uuids` flag has been added. * The `CASE_DEMO_NONRANDOM_UUID_BASE` environment variable can now be used to make non-inherent deterministic UUIDs. A follow-on patch will regenerate Make-managed files. References: * #54 * casework/CASE-Utilities-Python#112 * edmcouncil/rdf-toolkit#52 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Implementation-PROV-O
that referenced
this pull request
May 18, 2023
…nodes This patch uses the inherence UUID functions from `case-utils` PR 112 to replace the blank nodes generated with SPARQL Construct queries. As side effects of this migration, some bugs were fixed with generating some associations, and inherence modeling assumptions are now specified in code comments. This patch also adds `prov:Start` and `prov:End` nodes to reify `prov:Activity` (and `case-investigation:InvestigativeAction`) time boundaries. This will be a significant assistance in OWL-Time-based visualization under development for `case-prov` PR 54. Creating the `prov:Start` and `prov:End` nodes as IRI-identified is also necessary because of a bug observed in `rdf-toolkit`; see their Issue 52. Since `case_prov_rdf` will now be able to generate non-blank nodes, it has picked up two behaviors used in other projects importing `case-utils`: * The `--use-deterministic-uuids` flag has been added. * The `CASE_DEMO_NONRANDOM_UUID_BASE` environment variable can now be used to make non-inherent deterministic UUIDs. A follow-on patch will regenerate Make-managed files. References: * #54 * casework/CASE-Utilities-Python#112 * edmcouncil/rdf-toolkit#52 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to ajnelson-nist/CASE-Examples-QC
that referenced
this pull request
Dec 18, 2023
References: * casework/CASE-Utilities-Python#112 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to ajnelson-nist/CASE-Examples-QC
that referenced
this pull request
Dec 18, 2023
This is written in response to CASE website Issue 264. It accommodates UUIDv5s per the inherent UUID feature added in `case-utils`' PR 112. This patch is known to not pass `make check` in the current state of the examples. References: * casework/CASE-Utilities-Python#112 * casework/casework.github.io#264 Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates two others:
This should not be merged before a chance for discussion at the Adoption Committee meeting, 2023-05-09.