Fix DAP issues for Modal #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change role from main to dialog on div add label for dialog role remove banner and content-info per html 5 usage any to service method for compiling
aradhikaIbm
requested review from
cal-smith,
magedhennawy and
zvonimirfras
as code owners
|
Can we close on this change ? |
|
Waiting for another review ... @zvonimirfras ? |
zvonimirfras
requested changes
Oct 15, 2018
src/modal/modal.service.ts
Outdated
| @@ -87,7 +87,7 @@ export class ModalService { | |||
| * @returns {ComponentRef<any>} | |||
| * @memberof ModalService | |||
| */ | |||
| show(data: AlertModalData) { | |||
There was a problem hiding this comment.
This should stay indented. :)
zvonimirfras
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Closes IBM/carbon-components-angular #114
fixes #158
Resolves the DAP violations for the modal
Changelog
Changed