Skip to content

Let exceptions to bubble #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2020
Merged

Let exceptions to bubble #4

merged 6 commits into from
May 23, 2020

Conversation

nerg4l
Copy link
Member

@nerg4l nerg4l commented May 23, 2020

This PR allows exceptions (mainly GuzzleException) to bubble up to the caller of the client instance. Previous implementation swallowed it which made it hard to debug.

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #4 into master will increase coverage by 1.82%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     96.98%   98.81%   +1.82%     
- Complexity       57       58       +1     
============================================
  Files             1        2       +1     
  Lines           166      169       +3     
============================================
+ Hits            161      167       +6     
+ Misses            5        2       -3     
Flag Coverage Δ Complexity Δ
#unittests 98.81% <100.00%> (+1.82%) 58.00 <2.00> (+1.00)
Impacted Files Coverage Δ Complexity Δ
src/BroadcasttClient.php 98.78% <100.00%> (+1.79%) 56.00 <0.00> (-1.00) ⬆️
src/Exception/JsonEncodeException.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b535cb...9c29d49. Read the comment docs.

@nerg4l nerg4l merged commit a225707 into broadcastt:master May 23, 2020
@nerg4l nerg4l deleted the exception branch May 23, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant